[v3-0-test] Fix infinite redirect caused by mistakenly setting token cookie as secure (#49721) #49733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cookie as secure (#49721) `api/ssl_cert` has a default value of "" so `has_option` is always returning true, so we have to find in a slightly more complex way of telling if this setting is turned on. I have also updated the Simple security manager to look at X-Forwarded-Proto so that if there is a reverse proxy in front (and if Airflow is configured to trust that) then it sets the secure flag (cherry picked from commit 76edd92) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
vincbeck
approved these changes
Apr 24, 2025
ashb
reviewed
Apr 24, 2025
kaxil
pushed a commit
that referenced
this pull request
Apr 24, 2025
…cure (#49721) (#49733) `api/ssl_cert` has a default value of "" so `has_option` is always returning true, so we have to find in a slightly more complex way of telling if this setting is turned on. I have also updated the Simple security manager to look at X-Forwarded-Proto so that if there is a reverse proxy in front (and if Airflow is configured to trust that) then it sets the secure flag (cherry picked from commit 76edd92) Co-authored-by: Ash Berlin-Taylor <ash@apache.org> * Update airflow-core/docs/core-concepts/auth-manager/index.rst --------- Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api/ssl_certhas a default value of "" sohas_optionis always returningtrue, so we have to find in a slightly more complex way of telling if this
setting is turned on.
I have also updated the Simple security manager to look at X-Forwarded-Proto
so that if there is a reverse proxy in front (and if Airflow is configured to
trust that) then it sets the secure flag
(cherry picked from commit 76edd92)
Co-authored-by: Ash Berlin-Taylor ash@apache.org